Attention is currently required from: Jason Nien, Matt DeVillier, Jon Murphy, Martin Roth, Karthik Ramasubramanian.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73250 )
Change subject: mb/google/skryim: Add RECOVERY_MRC_CACHE FMAP section
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/73250/comment/471bfa86_6dcb1b1e
PS1, Line 25: RECOVERY_MRC_CACHE
any reason not to size the two MRC CACHE regions to 128k (to allow for 64k erase) and have them cont […]
would be good to have some numbers for read, write and erase speed to see if using 120k or 128k is faster in the most common cases. i'm not sure if 64k erases are that much faster compared to 16x 4k erases. also the read case should be much more common than the erase case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73250
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f0f41c20b61c96473e887521f84f3ad240adc2b
Gerrit-Change-Number: 73250
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 27 Feb 2023 19:26:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment