Change in coreboot[master]: nb/intel/i945/acpi: COnvert igd.asl to ASL+ Syntax

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

10 Sep 2020 10 Sep '20

6:54 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: COnvert igd.asl to ASL+ Syntax ......................................................................

nb/intel/i945/acpi: COnvert igd.asl to ASL+ Syntax

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/1

diff --git a/src/northbridge/intel/i945/acpi/igd.asl b/src/northbridge/intel/i945/acpi/igd.asl index 5258c52..43662d1 100644 --- a/src/northbridge/intel/i945/acpi/igd.asl +++ b/src/northbridge/intel/i945/acpi/igd.asl @@ -28,7 +28,7 @@

Method (XBCM, 1, NotSerialized) { - Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC) + ^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F) #ifdef SMI_SAVE_CMOS Trap(SMI_SAVE_CMOS) #endif @@ -36,8 +36,8 @@

Method (XBQC, 0, NotSerialized) { - Store (^^DSPC.BRTC, Local0) - ShiftRight (Local0, 4, Local0) + Local0 = ^^DSPC.BRTC + Local0 >>= 4 Return (Local0) } #include <drivers/intel/gma/acpi/common.asl>

Attachments:

attachment.htm (text/html — 2.9 KB)

Show replies by date

HAOUAS Elyes (Code Review)

11 Sep 11 Sep

2:25 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#2).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/2

HAOUAS Elyes (Code Review)

6:16 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

Set Ready For Review

HAOUAS Elyes (Code Review)

6:17 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

Patch Set 2: Code-Review-1

This change the binary for apple/macbook21.

HAOUAS Elyes (Code Review)

6:18 a.m.

New subject: Change in coreboot[master]: [WIP]nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#3).

Change subject: [WIP]nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

[WIP]nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

it changes the binary for apple/macbook21

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/3

HAOUAS Elyes (Code Review)

9:58 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#4).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

It changes the binary for apple/macbook21. The compiler didn't the same optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/4

HAOUAS Elyes (Code Review)

9:58 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

HAOUAS Elyes has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

Removed Code-Review-1 by HAOUAS Elyes ehaouas@noos.fr

Paul Menzel (Code Review)

12 Sep 12 Sep

8:39 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG@11 PS4, Line 11: "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)" If it should be the same, report this to the IASL developers?

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... File src/northbridge/intel/i945/acpi/igd.asl:

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... PS4, Line 42: } Due to the problem with the IASL optimization, split the commit into two, where one doesn’t change the binary, and the other does?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 12 Sep 2020 08:39:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

5:58 p.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL+ Syntax ......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/4//COMMIT_MSG@11 PS4, Line 11: "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"

...

If it should be the same, report this to the IASL developers?

Reported. Thx

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... File src/northbridge/intel/i945/acpi/igd.asl:

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... PS4, Line 42: }

...

Due to the problem with the IASL optimization, split the commit into two, where one doesn’t change t […]

let wait acpica's developers answer

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 12 Sep 2020 17:58:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

16 Sep 16 Sep

6:12 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#5).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

It changes the binary for apple/macbook21. The compiler didn't the same optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/5

HAOUAS Elyes (Code Review)

18 Sep 18 Sep

6:03 p.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... File src/northbridge/intel/i945/acpi/igd.asl:

https://review.coreboot.org/c/coreboot/+/45273/4/src/northbridge/intel/i945/... PS4, Line 42: }

...

let wait acpica's developers answer

Here is the answer from acpica's developers:

"Here's what I think is going on. Yes, the optimization is different between the two statements. From the listing file (-l compiler option):

18: Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)

0000003F: 70 ..................... "p" 00000040: 7D ..................... "}" 00000041: 79 68 0A 04 00 0A 0F 00 "yh......" 00000049: 5E 5E 2E 44 53 50 43 42 "^^.DSPCB" 00000051: 52 54 43 ............... "RTC"

19: ^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)

00000054: 7D ..................... "}" 00000055: 79 68 0A 04 00 0A 0F 5E "yh.....^" 0000005D: 5E 2E 44 53 50 43 42 52 "^.DSPCBR" 00000065: 54 43 .................. "TC"

In the first statement, the "Store" instruction (0x70) is simply passed through to the .aml In the second statement, the implied "Store" instruction (part of "^^DSPC.BRTC =" (the OR is opcode 0x7d) is optimized away, and the "Or" instruction does the "Store" as the third argument (the "target" operand).

Considering that the iASL compiler is essentially two compilers (Legacy ASL, and ASL v2), the Legacy ASL part of the compiler does not have the support to optimize the "Store" instruction away, but the ASL v2 compiler does have this support.

Thus, the resulting .aml files are different."

(https://github.com/acpica/acpica/issues/631)

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 18 Sep 2020 18:03:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

30 Sep 30 Sep

11:24 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#6).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

It changes the binary for apple/macbook21. The compiler didn't the same optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/6

HAOUAS Elyes (Code Review)

23 Jan 23 Jan

8:09 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#8).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Generated 'build/dsdt.dsl' files for ibase/mb899 are identical.

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/8

Michael Niewöhner (Code Review)

24 Jan 24 Jan

9:37 p.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 8:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/comment/5ad0c60e_76e01767 PS8, Line 9: Generated 'build/dsdt.dsl' files for ibase/mb899 are identical. they were not, what changed?

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Sun, 24 Jan 2021 21:37:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

25 Jan 25 Jan

6:56 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 8:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/comment/ab77a29e_8b910b0a PS8, Line 9: Generated 'build/dsdt.dsl' files for ibase/mb899 are identical.

...

they were not, what changed?

Thx a part of commit msg has gone. I'll fix it. It changes the binary as legacy compiler didn't the same optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)"

However, generated "dsdt.dsl" files are identical. the difference is in files comments: diff dsdt.dsl build/dsdt.dsl 8c8 < * Disassembly of build/dsdt.aml, Mon Jan 25 06:44:35 2021 ---

...

Disassembly of build/dsdt.aml, Mon Jan 25 06:47:20 2021

12c12 < * Length 0x0000241C (9244) ---

...

```
Length           0x0000241A (9242)
```

14c14 < * Checksum 0xD7 ---

...

```
Checksum         0x51
```

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 8 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Mon, 25 Jan 2021 06:56:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:02 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Michael Niewöhner. Hello build bot (Jenkins), Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45273

to look at the new patch set (#9).

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Generated 'build/dsdt.dsl' files for ibase/mb899 are identical. It changes the binary, as legacy compiler does not have the optimization for "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)" instructions, but the ASL v2 compiler does have.

(see https://github.com/acpica/acpica/issues/631)

Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/acpi/igd.asl 1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/45273/9

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

26 Jan 26 Jan

8:17 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 9:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/comment/6ed288b9_56c1ee5b PS8, Line 9: Generated 'build/dsdt.dsl' files for ibase/mb899 are identical.

...

Thx […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 9 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Tue, 26 Jan 2021 08:17:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner foss@mniewoehner.de Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

17 Feb 17 Feb

9:53 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Nico Huber, Michael Niewöhner, HAOUAS Elyes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 11: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/comment/cb32e9b6_b27e4e84 PS11, Line 12: instructions, but the ASL v2 compiler does have. Please wrap lines at 72 characters:

Generated 'build/dsdt.dsl' files for ibase/mb899 are identical. Since the "Store (Or(ShiftLeft (Arg0, 4), 0xf), ^^DSPC.BRTC)" and "^^DSPC.BRTC = ((Arg0 << 0x04) | 0x0F)" statements get optimized differently by the ASL v2 compiler, the resulting binary changes.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 11 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 17 Feb 2021 09:53:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

11:25 a.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Nico Huber, Michael Niewöhner. HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 12:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/45273/comment/89ecc6cd_1b3c8892 PS11, Line 12: instructions, but the ASL v2 compiler does have.

...

Please wrap lines at 72 characters: […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-Comment-Date: Wed, 17 Feb 2021 11:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:25 p.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

Attention is currently required from: Nico Huber, Michael Niewöhner, HAOUAS Elyes. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Patch Set 12: Code-Review+1

(1 comment)

Patchset:

PS12: I’d still prefer two commits, but not that important.

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Wed, 17 Feb 2021 16:25:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:25 p.m.

New subject: Change in coreboot[master]: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45273 )

Change subject: nb/intel/i945/acpi: Convert igd.asl to ASL 2.0 syntax ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/45273 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0c3063b5a448fee4bcf283e56e7dc2008edcf7c Gerrit-Change-Number: 45273 Gerrit-PatchSet: 12 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Michael Niewöhner foss@mniewoehner.de Gerrit-MessageType: abandon

1381

days inactive

1541

days old

coreboot-gerrit@coreboot.org

20 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)
Michael Niewöhner (Code Review)
Paul Menzel (Code Review)