Change in coreboot[master]: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section o...

[Martin Roth (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Chris Wang, Patrick Huang, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52544 )

Change subject: src/vendorcode/amd/fsp/picasso: Add HDMI 2.0 diable setting section of FspmUpd.h
......................................................................

Patch Set 3:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/52544/comment/aaa3d8e8_45c63e8f 
PS3, Line 7: diable
disable

https://review.coreboot.org/c/coreboot/+/52544/comment/b8db94d3_27d56c4d 
PS3, Line 9: for customized project
I'd remove this - it doesn't matter what project it's for since it's going into generic code.

https://review.coreboot.org/c/coreboot/+/52544/comment/dd51561b_6235c80e 
PS3, Line 13: system integrated table
to the FSP?

File src/vendorcode/amd/fsp/picasso/FspmUpd.h:

https://review.coreboot.org/c/coreboot/+/52544/comment/adaf1456_34767386 
PS3, Line 67: UnusedUpdSpace1;
Felix: Why is this left as "unused"?  Shouldn't this have been updated in a previous patch?  It looks like it was assigned in the FSP by Matt back in October 2020.

https://review.coreboot.org/c/coreboot/+/52544/comment/fcea0656_846d83eb 
PS3, Line 71: hdmi2_disable3
Maybe name these as:
disable_hdmi2_ddi0
disable_hdmi2_ddi1
disable_hdmi2_ddi2
disable_hdmi2_ddi3