[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Enable FPS - coreboot-gerrit

13 Jan 2025


      Attention is currently required from: Subrata Banik.
Cliff Huang has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85687?usp=email )
Change subject: mb/google/fatcat/var/fatcat: Enable FPS
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/fatcat/variants/fatcat/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85687/comment/507274a8_d3fe983c?usp... :
PS6, Line 110: 	register "serial_io_gspi_mode" = "{
...
Can we consider adding this to SOC based on if the corresponding PCIe device is set to enable? […]
I take my comment back. I saw fill_fsps_lpss_params in place for gspi.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85687?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifced5c779407b4ffcc69a7ed1297704def09b554
Gerrit-Change-Number: 85687
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Pranava Y N pranavayn@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Cliff Huang cliff.huang@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Comment-Date: Tue, 14 Jan 2025 00:39:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Cliff Huang cliff.huang@intel.com