Martin Roth has posted comments on this change. ( https://review.coreboot.org/28374 )
Change subject: mainboard/google/kahlee: Enable EC firmware update screen ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig File src/mainboard/google/kahlee/Kconfig:
https://review.coreboot.org/#/c/28374/1/src/mainboard/google/kahlee/Kconfig@... PS1, Line 101: if VBOOT_EC_SOFTWARE_SYNC
nit: VBOOT_EC_SLOW_UPDATE already has a 'depends on VBOOT_EC_SOFTWARE_SYNC', this if clause is prett […]
Unfortunately, select statements override "depends on", so the 'if' is needed.
From the Kconfig doc:
https://doc.coreboot.org/getting_started/kconfig.html
Select statement usage The ‘select’ keyword forces the value of a symbol with a bool type to ‘y’. It overrides any dependencies of the symbol, so using it carelessly can lead to unpredictable results.
-
Martin Roth (Code Review)