Attention is currently required from: Subrata Banik, Paul Menzel, Kapil Porwal, Sridhar Siricilla.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74995 )
Change subject: soc/intel/cmd/block/cse: Store CSE version in CMOS memory
......................................................................
Patch Set 20:
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/74995/comment/e475405a_599c2512
PS9, Line 1233: write current ISH version to CBMEM memory.
Do you mean system takes more time to access the CMOS than CBMEM? […]
CMOS memory is persistent over reboot, that helps to retain the ISH version.
CBMEM memory is volatile memory and comparatively faster. For this reason, we use CBMEM stored ISH version for the user-exposed API.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74995
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd0ee19575683691c0a82a291e1fd3b2ffb11786
Gerrit-Change-Number: 74995
Gerrit-PatchSet: 20
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Mon, 22 May 2023 10:37:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment