Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/libhwbase/+/39163 )
Change subject: Makefile: Adapt $(space) definition ......................................................................
Makefile: Adapt $(space) definition
GNU Make 4.3 is more picky about the $(space) definition. It seems that the variable ends up being empty.
Change-Id: If07db29fc63e8a45e9b0869df894ce3420fa9b95 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libhwbase refs/changes/63/39163/1
diff --git a/Makefile b/Makefile index a25deb6..14a7d4f 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ $(binary):
space := -space += +space := $(space) $(space) comma := ,
strip_quotes = $(strip $(subst ",,$(1)))
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/39163 )
Change subject: Makefile: Adapt $(space) definition ......................................................................
Patch Set 1: Verified+1 Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/39163 )
Change subject: Makefile: Adapt $(space) definition ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libhwbase/+/39163 )
Change subject: Makefile: Adapt $(space) definition ......................................................................
Patch Set 1: Code-Review+2
Saw some discussion on IRC. I guess one could write it less confusing by adding another variable, e.g.
empty := space := $(empty) $(empty)
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/libhwbase/+/39163 )
Change subject: Makefile: Adapt $(space) definition ......................................................................
Makefile: Adapt $(space) definition
GNU Make 4.3 is more picky about the $(space) definition. It seems that the variable ends up being empty.
Change-Id: If07db29fc63e8a45e9b0869df894ce3420fa9b95 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/libhwbase/+/39163 Tested-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Patrick Georgi: Verified; Looks good to me, approved Nico Huber: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/Makefile b/Makefile index a25deb6..14a7d4f 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ $(binary):
space := -space += +space := $(space) $(space) comma := ,
strip_quotes = $(strip $(subst ",,$(1)))
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)