Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Karthik Ramasubramanian, Felix Held.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51540 )
Change subject: mb/google/guybrush: Configure UART0 gpio in early stage
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51540/comment/02dab6f9_d05eba05
PS1, Line 141: UART0 configured in early stage
All GPIOs must be configured in ramstage irrespective of whether they were configured in early stage […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aa54acf1fa9295b27c33a0066432665e6e3755c
Gerrit-Change-Number: 51540
Gerrit-PatchSet: 2
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 16 Mar 2021 20:58:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment