Change in coreboot[master]: soc/intel/common: Add CPU related APIs

[Tim Wawrzynczak (Code Review)]

Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Sugnan Prabhu S, Sridhar Siricilla, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 )

Change subject: soc/intel/common: Add CPU related APIs
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/c/coreboot/+/59124/comment/df533bbb_3f913564 
PS8, Line 210: union cpuid_nat_model_id_and_core_type {
             : 		struct {
             : 			u32 native_mode_id:24;
             : 			u32 core_type:8;
             : 		} bits;
             : 		u32 hybrid_info;
             : 	};
             : 	union cpuid_nat_model_id_and_core_type eax;
nit: you don't have to change this, but you don't need the name for the union, e.g.

```
union {
	struct {
		u32 native_mode_id:24;
		u32 core_type:8;
	} bits;
	u32 hybrid_info;
} eax;

eax.hybrid_info = cpuid_eax(...)
```
```



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59124
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I680f43952ab4abce6e342206688ad32814970a91
Gerrit-Change-Number: 59124
Gerrit-PatchSet: 8
Gerrit-Owner: Sridhar Siricilla <[e-mail]>
Gerrit-Reviewer: Maulik V Vaghela <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: Subrata Banik <[e-mail]>
Gerrit-Reviewer: Sugnan Prabhu S <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Arthur Heymans <[e-mail]>
Gerrit-CC: Michael Niewöhner <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Sridhar Siricilla <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Nico Huber <[e-mail]>
Gerrit-Attention: Maulik V Vaghela <[e-mail]>
Gerrit-Attention: Sugnan Prabhu S <[e-mail]>
Gerrit-Attention: Sridhar Siricilla <[e-mail]>
Gerrit-Attention: Subrata Banik <[e-mail]>
Gerrit-Attention: Patrick Rudolph <[e-mail]>
Gerrit-Comment-Date: Fri, 03 Dec 2021 20:46:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment