Attention is currently required from: Arthur Heymans, Nico Huber, Maulik V Vaghela, Sugnan Prabhu S, Sridhar Siricilla, Subrata Banik, Patrick Rudolph.

Patch set 8:Code-Review +2

View Change

1 comment:

• File src/soc/intel/common/block/cpu/cpulib.c:

  • Patch Set #8, Line 210:

    union cpuid_nat_model_id_and_core_type {
    		struct {
    			u32 native_mode_id:24;
    			u32 core_type:8;
    		} bits;
    		u32 hybrid_info;
    	};
    	union cpuid_nat_model_id_and_core_type eax;
    

    nit: you don't have to change this, but you don't need the name for the union, e.g.

    ```
    union {
    	struct {
    		u32 native_mode_id:24;
    		u32 core_type:8;
    	} bits;
    	u32 hybrid_info;
    } eax;

    eax.hybrid_info = cpuid_eax(...)
    ```
    ```

To view, visit change 59124. To unsubscribe, or for help writing mail filters, visit settings.