Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec

[John Su (Code Review)]

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33384

Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
......................................................................

mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec

After adjustment on Hatch
Touch Pad CLK: 383.4 KHz

BUG=b:134911522
BRANCH=master
TEST=emerge-hatch coreboot chromeos-bootimage
     measure by scope with hatch.

Change-Id: Iee2b692c268381af267b70e92a577ac89ce41cbb
Signed-off-by: John Su 
---
M src/mainboard/google/hatch/variants/hatch/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33384/1

diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index 562bb8b..0d434f3 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -35,6 +35,8 @@
    	},
    	.i2c[0] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 50,
+			.fall_time_ns = 15,
    	},
    	.i2c[1] = {
    		.speed = I2C_SPEED_FAST,

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33384/1/src/mainboard/google/hatch/variants/... 
File src/mainboard/google/hatch/variants/hatch/overridetree.cb:

https://review.coreboot.org/#/c/33384/1/src/mainboard/google/hatch/variants/... 
PS1, Line 41: 		.i2c[1] = {
What about the other I2C buses?

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
......................................................................

Patch Set 1:
> Patch Set 1:
>
> (1 comment)

Wait to tune other i2c buses.
I will update CL together.

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
......................................................................

Patch Set 1:

May Intel suggest a default value for each bus? We can keep a default for non-connect one.

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust touchpad I2C CLK to meet spec
......................................................................

Patch Set 1:
> Patch Set 1:
>
> May Intel suggest a default value for each bus? We can keep a default for non-connect one.

You don't need a value for the unused buses.

Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

[John Su (Code Review)]

Hello Ivy Jian, EricR Lai, Chris Zhou, Paul Fagerburg, JoeJ Chang, Philip Chen, Tim Wawrzynczak, Van Chen, Frank Wu, Shelley Chen, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33384

to look at the new patch set (#2).

Change subject: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec
......................................................................

mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

After adjustment on Hatch
Touch Pad CLK: 383.4 KHz
Touch Screen CLK: 381.6 KHz
SAR Sensor CLK: 392.0 KHz
Audio codec CLK: 386.0 KHz

BUG=b:134911522
BRANCH=master
TEST=emerge-hatch coreboot chromeos-bootimage
     measure by scope with hatch.

Change-Id: Iee2b692c268381af267b70e92a577ac89ce41cbb
Signed-off-by: John Su 
---
M src/mainboard/google/hatch/variants/hatch/overridetree.cb
1 file changed, 11 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/33384/2

Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

[Paul Fagerburg (Code Review)]

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec
......................................................................

Patch Set 2: Code-Review+1

Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec
......................................................................

Patch Set 2: Code-Review+2

Change in ...coreboot[master]: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

[Furquan Shaikh (Code Review)]

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33384 )

Change subject: mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec
......................................................................

mb/google/hatch/variants/hatch: Adjust all I2C CLK to meet spec

After adjustment on Hatch
Touch Pad CLK: 383.4 KHz
Touch Screen CLK: 381.6 KHz
SAR Sensor CLK: 392.0 KHz
Audio codec CLK: 386.0 KHz

BUG=b:134911522
BRANCH=master
TEST=emerge-hatch coreboot chromeos-bootimage
     measure by scope with hatch.

Change-Id: Iee2b692c268381af267b70e92a577ac89ce41cbb
Signed-off-by: John Su 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33384
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Fagerburg 
Reviewed-by: Furquan Shaikh 
---
M src/mainboard/google/hatch/variants/hatch/overridetree.cb
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Paul Fagerburg: Looks good to me, but someone else must approve

diff --git a/src/mainboard/google/hatch/variants/hatch/overridetree.cb b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
index 3846b60..d676843 100644
--- a/src/mainboard/google/hatch/variants/hatch/overridetree.cb
+++ b/src/mainboard/google/hatch/variants/hatch/overridetree.cb
@@ -35,12 +35,23 @@
    	},
    	.i2c[0] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 50,
+			.fall_time_ns = 15,
    	},
    	.i2c[1] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 60,
+			.fall_time_ns = 25,
+		},
+		.i2c[3] = {
+			.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 150,
+			.fall_time_ns = 150,
    	},
    	.i2c[4] = {
    		.speed = I2C_SPEED_FAST,
+			.rise_time_ns = 120,
+			.fall_time_ns = 120,
    	},
    }"