[M] Change in coreboot[main]: drivers/asmedia: Add code to enable AHCI for ASM1061 - coreboot-gerrit

2 Jan 2025


      Attention is currently required from: Angel Pons, Jan Philipp Groß.
Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85816?usp=email )
Change subject: drivers/asmedia: Add code to enable AHCI for ASM1061
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/asmedia/asm1061.c:
https://review.coreboot.org/c/coreboot/+/85816/comment/1ea2d8ec_dbe74f02?usp... :
PS5, Line 40: 	0x0611, /* ASM1061 SATA IDE Controller */
...
Does the device ID change when switching to SATA mode?
Yes, the device ID changes from 0x611 to 0x0612 after the subclass code register is written.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85816?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a1470894261c7d14fadccdcade968f87f78fe23
Gerrit-Change-Number: 85816
Gerrit-PatchSet: 5
Gerrit-Owner: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Jan Philipp Groß jeangrande@mailbox.org
Gerrit-Reviewer: Riku Viitanen riku.viitanen@protonmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jan Philipp Groß jeangrande@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 02 Jan 2025 14:20:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com