Attention is currently required from: Hung-Te Lin, jitao shi, Yu-Ping Wu.
Chen-Tsung Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51434 )
Change subject: soc/mediatek: make sure force hsa hsa hfp packet multiple of line_num
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/51434/comment/4036fe1a_e946ca2d
PS1, Line 243: ((hsync_active_byte + lanes - 1) / lanes)
Please use DIV_ROUND_UP(hsync_active_byte, lanes) as Yuping indecated in https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+....
There is no ROUND_UP in coreboot, but "DIV_ROUND_UP(hsync_active_byte, lanes) * lines" works as ROUND_UP.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5949de1a9a1947fa188233787166a478b1de68b5
Gerrit-Change-Number: 51434
Gerrit-PatchSet: 1
Gerrit-Owner: jitao shi
jitao.shi@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Chen-Tsung Hsieh
chentsung@chromium.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: jitao shi
jitao.shi@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 15 Mar 2021 10:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment