Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29754 )
Change subject: soc/intel/common/acpi: Add common CPU methods ......................................................................
Patch Set 1:
Patch Set 1:
It is a good idea, but I think it is a much larger change than just fixing the cannonlake bug where these methods don't exist, which I could do instead of refactoring it into common code if we want to instead push for a change in this direction.
However, I think calling back into an SSDT from the DSDT is still not allowed by the linux kernel, and currently all the DPTF code is in the DSDT...
https://review.coreboot.org/q/topic:%22common_cpu_asl%22+(status:open%20OR%2...) implements it for almost all intel targets. (fully untested)
-
Arthur Heymans (Code Review)