Change in coreboot[master]: mb/google/hatch/var/kindred:: Add enable signal for touch screen

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Philip Chen (Code Review)

23 Aug 2019 23 Aug '19

6:26 a.m.

Philip Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

mb/google/hatch/var/kindred:: Add enable signal for touch screen

In the next board version, we will use GPP_D9 as enable control for touch screen.

BUG=b:137133946 TEST=build

Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Signed-off-by: Philip Chen philipchen@google.com --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 15 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/35039/1

diff --git a/src/mainboard/google/hatch/variants/kindred/overridetree.cb b/src/mainboard/google/hatch/variants/kindred/overridetree.cb index de633e3..a4ca176 100644 --- a/src/mainboard/google/hatch/variants/kindred/overridetree.cb +++ b/src/mainboard/google/hatch/variants/kindred/overridetree.cb @@ -78,9 +78,10 @@ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "reset_delay_ms" = "100" register "reset_off_delay_ms" = "5" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "enable_delay_ms" = "10" + register "enable_off_delay_ms" = "1" register "has_power_resource" = "1" - register "stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C4)" - register "stop_off_delay_ms" = "5" device i2c 49 on end end chip drivers/i2c/generic @@ -91,22 +92,12 @@ register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" register "reset_delay_ms" = "1" register "reset_off_delay_ms" = "2" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D9)" + register "enable_delay_ms" = "10" + register "enable_off_delay_ms" = "1" register "has_power_resource" = "1" device i2c 39 on end end - chip drivers/i2c/hid - register "generic.hid" = ""GDIX0000"" - register "generic.desc" = ""Goodix Touchscreen"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_D16_IRQ)" - register "generic.probed" = "1" - register "generic.reset_gpio" = - "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D15)" - register "generic.reset_delay_ms" = "10" - register "generic.reset_off_delay_ms" = "1" - register "generic.has_power_resource" = "1" - register "hid_desc_reg_offset" = "0x01" - device i2c 5d on end - end chip drivers/generic/gpio_keys register "name" = ""PENH"" register "gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_A8)"

Attachments:

attachment.htm (text/html — 5.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

23 Aug 23 Aug

9:13 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... PS1, Line 81: GPP_D9 Is this GPIO configured correctly?

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 07:13:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Wu (Code Review)

9:39 a.m.

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... PS1, Line 81: GPP_D9

...

Is this GPIO configured correctly?

Yes, please refer to Kindred MB schematic rev V2.7 20190822 https://partnerissuetracker.corp.google.com/issues/133595720#comment5

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 07:39:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9:50 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... PS1, Line 81: GPP_D9

...

Yes, please refer to Kindred MB schematic rev V2.7 20190822 […]

I meant if it was configured correctly in gpio.c in coreboot. Looks like it is done in baseboard/gpio.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 07:50:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Philip Chen (Code Review)

9:56 a.m.

Philip Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... PS1, Line 81: GPP_D9

...

I meant if it was configured correctly in gpio.c in coreboot. […]

Yes, I already confirmed GPP_D9 is configured right in baseboard. I was checking schematic v2.6 when submitting the CL. I just checked again with v2.7 - no change for this CL is needed.

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 07:56:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

3 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 13:00:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:57 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/kindred/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/35039/1/src/mainboard/google/hatch/... PS1, Line 81: GPP_D9

...

Yes, I already confirmed GPP_D9 is configured right in baseboard. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 15:57:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Philip Chen philipchen@google.com Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Tim Wawrzynczak (Code Review)

5:57 p.m.

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 23 Aug 2019 15:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

6:18 p.m.

Furquan Shaikh has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/35039 )

Change subject: mb/google/hatch/var/kindred:: Add enable signal for touch screen ......................................................................

mb/google/hatch/var/kindred:: Add enable signal for touch screen

In the next board version, we will use GPP_D9 as enable control for touch screen.

BUG=b:137133946 TEST=build

Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Signed-off-by: Philip Chen philipchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35039 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/hatch/variants/kindred/overridetree.cb 1 file changed, 6 insertions(+), 15 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved Paul Fagerburg: Looks good to me, approved

-- To view, visit https://review.coreboot.org/c/coreboot/+/35039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I213d0878bfca1ce4059ec0393f59d8e79e1b274c Gerrit-Change-Number: 35039 Gerrit-PatchSet: 2 Gerrit-Owner: Philip Chen philipchen@google.com Gerrit-Reviewer: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Philip Chen philipchen@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2076

days inactive

2076

days old

coreboot-gerrit@coreboot.org

8 comments

5 participants

tags (0)

participants (5)

David Wu (Code Review)
Furquan Shaikh (Code Review)
Paul Fagerburg (Code Review)
Philip Chen (Code Review)
Tim Wawrzynczak (Code Review)