Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40581 )
Change subject: mb/clevo/n141cu: Add new Comet Lake mainboard ......................................................................
Patch Set 32:
(6 comments)
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 38: default "clevo/cml-u" : : config VARIANT_DIR : default "n141cu" : : config MAINBOARD_FAMILY : default "Comet Lake" :
hmm, are there multiple latops that are expected to be mostly idenatical or at least very similar?
Yes, the Clevo notebooks have a very similar layout and therefore we can sum up them by platform.
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/board_info.txt:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 2: Board name: cml-u
that's not the board/laptop name, is it?
Removed that and created board_info.txt in the variants folder.
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 11: Make M.2 port configurable (SATA <>
It usually boils down to configuring a GPIO properly
Correct. Depending on the function you want, you just need to set a different GPIO configuration.
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 35: subsystemid 0x1558 0x1403
you can inherit that
Done
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 169: register "deep_s3_enable_ac" = "0"
you can drop the 0 values, since they are default
Done
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... File src/mainboard/clevo/cml-u/variants/n141cu/gma-mainboard.ads:
https://review.coreboot.org/c/coreboot/+/40581/31/src/mainboard/clevo/cml-u/... PS31, Line 13: P1, : DP2, : DP3, : HDMI1, : HDMI2, : HDMI3, : eDP, : others
so many ports?
libgfxinit doesn't have support for this platform yet and at the moment this file is unused. Therefore I am not able to test the ports.
Nevertheless I added all necessary so that once libgfxinit has support for it one just needs to remove the # in the Kconfig.