John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41064 )
Change subject: soc/intel/tigerlake: Add PMC to platform ACPI name entry ......................................................................
soc/intel/tigerlake: Add PMC to platform ACPI name entry
PMC device name string "PMC" is added to platform soc_acpi_name() for pmc driver.
BUG=b:151646486 TEST=Built and booted to kernel successfully.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ida7fc7e2340f2a809464ca66fd1922f3229e2e18 --- M src/soc/intel/tigerlake/chip.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/41064/1
diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 073c8d2..b806dbb 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -80,6 +80,7 @@ case PCH_DEVFN_PCIE10: return "RP10"; case PCH_DEVFN_PCIE11: return "RP11"; case PCH_DEVFN_PCIE12: return "RP12"; + case PCH_DEVFN_PMC: return "PMC"; case PCH_DEVFN_UART0: return "UAR0"; case PCH_DEVFN_UART1: return "UAR1"; case PCH_DEVFN_UART2: return "UAR2";
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41064 )
Change subject: soc/intel/tigerlake: Add PMC to platform ACPI name entry ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41064 )
Change subject: soc/intel/tigerlake: Add PMC to platform ACPI name entry ......................................................................
soc/intel/tigerlake: Add PMC to platform ACPI name entry
PMC device name string "PMC" is added to platform soc_acpi_name() for pmc driver.
BUG=b:151646486 TEST=Built and booted to kernel successfully.
Signed-off-by: John Zhao john.zhao@intel.com Change-Id: Ida7fc7e2340f2a809464ca66fd1922f3229e2e18 Reviewed-on: https://review.coreboot.org/c/coreboot/+/41064 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/soc/intel/tigerlake/chip.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/chip.c b/src/soc/intel/tigerlake/chip.c index 073c8d2..b806dbb 100644 --- a/src/soc/intel/tigerlake/chip.c +++ b/src/soc/intel/tigerlake/chip.c @@ -80,6 +80,7 @@ case PCH_DEVFN_PCIE10: return "RP10"; case PCH_DEVFN_PCIE11: return "RP11"; case PCH_DEVFN_PCIE12: return "RP12"; + case PCH_DEVFN_PMC: return "PMC"; case PCH_DEVFN_UART0: return "UAR0"; case PCH_DEVFN_UART1: return "UAR1"; case PCH_DEVFN_UART2: return "UAR2";
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41064 )
Change subject: soc/intel/tigerlake: Add PMC to platform ACPI name entry ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3249 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3248 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3247 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3246
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
John Zhao (Code Review)
-
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)