Attention is currently required from: Pranava Y N, Sukumar Ghorai.
Subrata Banik has posted comments on this change by Sukumar Ghorai. ( https://review.coreboot.org/c/coreboot/+/84957?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/fatcat/var/fatcat: Configure eSPI alarm GPIO
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84957/comment/7c153363_9f6bb3ad?usp... :
PS5, Line 9: This patch configures the ESPI_SOC_ALERT_L GPIO pad on fatcat as NC to enable S0ix low power entry.
please use line break at < 72 char
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84957?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icb80a56177105c0281d05fe1f5daa87e6f7e291f
Gerrit-Change-Number: 84957
Gerrit-PatchSet: 5
Gerrit-Owner: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Sun, 03 Nov 2024 07:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes