Peichao Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44588 )
Change subject: mb/google/dedede/var/boten: Add LTE power on/off sequence ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/boten/gpio.c:
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... PS10, Line 11: 1
That is what I wrote in patchset 9 and it was verified to meet the power sequence requirement. […]
Dear Furquan and Karthik, if set its value equal 0, LTE module can not work, we have do the experiment like ticket: https://partnerissuetracker.corp.google.com/issues/163100335#comment94
Thanks a lot
https://review.coreboot.org/c/coreboot/+/44588/10/src/mainboard/google/deded... PS10, Line 45: 1
Shouldn't this be 0? Since it is being deasserted by the ACPI methods?
I think ACPI still not validation if set value equal 0 in here.
-
Peichao Wang (Code Review)