Change in ...coreboot[master]: mb/google/kukui: Add default HWID for Chrome OS
Hung-Te Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31088 Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... mb/google/kukui: Add default HWID for Chrome OS The default value for Chrome OS HWID should be different. Calculated as HWID v1. BUG=None BRANCH=kukui TEST=build and boots properly. Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Signed-off-by: Hung-Te Lin <hungte@chromium.org> --- M src/mainboard/google/kukui/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/31088/1 diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 7635e5f..1a594a3 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -59,4 +59,9 @@ hex default 0x2 +config GBB_HWID + string + depends on CHROMEOS + default "KUKUI TEST 9847" + endif -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 1 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-MessageType: newchange
Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 1 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 07:56:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 1: Should we also add flapjack default HWID? -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 1 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 08:03:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Hello Nicolas Boichat, Julius Werner, You-Cheng Syu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31088 to look at the new patch set (#2). Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... mb/google/kukui: Add default HWID for Chrome OS The default value for Chrome OS HWID should be different. Calculated as HWID v1. BUG=b:123336677 BRANCH=kukui TEST=build and boots properly. Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Signed-off-by: Hung-Te Lin <hungte@chromium.org> --- M src/mainboard/google/kukui/Kconfig 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/31088/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 2 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-MessageType: newpatchset
Hello Nicolas Boichat, Julius Werner, You-Cheng Syu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/31088 to look at the new patch set (#3). Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... mb/google/kukui: Add default HWID for Chrome OS The default value for Chrome OS HWID should be different. Calculated as HWID v1. BUG=b:123336677 BRANCH=kukui TEST=build and boots properly. Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Signed-off-by: Hung-Te Lin <hungte@chromium.org> --- M src/mainboard/google/kukui/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/31088/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 3 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-MessageType: newpatchset
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 3:
Should we also add flapjack default HWID?
Done -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 3 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 08:20:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 3 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 09:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 3: ping - @jwerner, are you ok with this? -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 3 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Thu, 31 Jan 2019 04:05:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 3 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-Comment-Date: Thu, 31 Jan 2019 19:30:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31088 ) Change subject: mb/google/kukui: Add default HWID for Chrome OS ...................................................................... mb/google/kukui: Add default HWID for Chrome OS The default value for Chrome OS HWID should be different. Calculated as HWID v1. BUG=b:123336677 BRANCH=kukui TEST=build and boots properly. Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Signed-off-by: Hung-Te Lin <hungte@chromium.org> Reviewed-on: https://review.coreboot.org/c/31088 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: You-Cheng Syu <youcheng@google.com> Reviewed-by: Julius Werner <jwerner@chromium.org> --- M src/mainboard/google/kukui/Kconfig 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Julius Werner: Looks good to me, approved You-Cheng Syu: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/kukui/Kconfig b/src/mainboard/google/kukui/Kconfig index 7635e5f..9f477e5 100644 --- a/src/mainboard/google/kukui/Kconfig +++ b/src/mainboard/google/kukui/Kconfig @@ -59,4 +59,10 @@ hex default 0x2 +config GBB_HWID + string + depends on CHROMEOS + default "KUKUI TEST 9847" if BOARD_GOOGLE_KUKUI + default "FLAPJACK TEST 4147" if BOARD_GOOGLE_FLAPJACK + endif -- To view, visit https://review.coreboot.org/c/coreboot/+/31088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39c640562c1c3b117292b8abacd36a4a9c2fa6c6 Gerrit-Change-Number: 31088 Gerrit-PatchSet: 4 Gerrit-Owner: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Nicolas Boichat <drinkcat@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: You-Cheng Syu <youcheng@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Tristan Hsieh <tristan.shieh@mediatek.com> Gerrit-MessageType: merged
participants (5)
-
Hung-Te Lin (Code Review) -
Julius Werner (Code Review)
-
Nicolas Boichat (Code Review)
-
Patrick Georgi (Code Review)
-
You-Cheng Syu (Code Review)