Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Craig Hesling.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50828 )
Change subject: mb/google/volteer: Fix FPMCU pwr/rst gpio handling
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/50828/comment/c2d75066_22d9cbff
PS8, Line 10: 2. Disable power and assert reset in ramstage gpio
Duncan, any chance to test this yet?
I had tested the previous version, just tested this iteration and it still works.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib51815349cea299907c10d6c56c27bd239e499e7
Gerrit-Change-Number: 50828
Gerrit-PatchSet: 9
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Craig Hesling
hesling@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Craig Hesling
hesling@chromium.org
Gerrit-Comment-Date: Mon, 01 Mar 2021 21:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Duncan Laurie
dlaurie@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment