Attention is currently required from: Jayvik Desai, Kapil Porwal, Pranava Y N.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/87092?usp=email )
Change subject: commonlib/storage: Include pci_def.h ......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/storage/pci_sdhci.c:
https://review.coreboot.org/c/coreboot/+/87092/comment/73f68a9c_16eb6567?usp... : PS2, Line 5: #include <device/pci_def.h>
This is already part of above header when CONFIG_PCI is enabled.
The addition of pci_sdhci.c without depending on CONFIG_PCI causes issues when PCI kconfig is disabled, resulting in missing macro errors during compilation.
``` src/commonlib/storage/Makefile.mk:22:bootblock-y += pci_sdhci.c src/commonlib/storage/Makefile.mk:27:verstage-y += pci_sdhci.c src/commonlib/storage/Makefile.mk:32:romstage-y += pci_sdhci.c src/commonlib/storage/Makefile.mk:37:postcar-y += pci_sdhci.c src/commonlib/storage/Makefile.mk:42:ramstage-y += pci_sdhci.c ```