Attention is currently required from: Martin Roth, Tim Wawrzynczak, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49943 )
Change subject: This change implements CrashLog for intel TGL. ......................................................................
Patch Set 4:
(4 comments)
File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/49943/comment/732d1546_99b9deb2 PS4, Line 416: if (!CONFIG(SOC_INTEL_CRASHLOG)) { braces {} are not necessary for single statement blocks
File src/soc/intel/tigerlake/crashlog_lib.c:
https://review.coreboot.org/c/coreboot/+/49943/comment/729f1daa_95c67d33 PS4, Line 73: printk(BIOS_ERR, "pmc_send_ipc_cmd failed in %s\n",__func__); space required after that ',' (ctx:VxV)
File src/soc/intel/tigerlake/include/soc/crashlog_def.h:
https://review.coreboot.org/c/coreboot/+/49943/comment/14b5c2e0_532fc465 PS4, Line 6: include <types.h> spaces required around that '<' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/49943/comment/7f5562d9_50d2c27d PS4, Line 6: include <types.h> spaces required around that '>' (ctx:VxE)