Change in coreboot[master]: util/autoport: Stop generate empty h8_mainboard_init_dock().
Bill XIE has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36752 )
Change subject: util/autoport: Stop generate empty h8_mainboard_init_dock(). ......................................................................
util/autoport: Stop generate empty h8_mainboard_init_dock().
CB:36385 makes dock init in ramstage fully mainboard-specific, so keeping generating empty h8_mainboard_init_dock() for lenovo EC becomes unnecessary and problematic.
Change-Id: I19f57f41403ffd0319cc86f21bec7e142095df83 Signed-off-by: Bill XIE persmule@hardenedlinux.org --- M util/autoport/ec_lenovo.go M util/autoport/readme.md 2 files changed, 3 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/36752/1
diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index c2dd333..9384896 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -59,20 +59,6 @@
si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n")
- dock := Create(ctx, "dock.c") - defer dock.Close() - - AddRAMStageFile("dock.c", "") - - dock.WriteString( - `#include <ec/lenovo/h8/h8.h> - -void h8_mainboard_init_dock (void) -{ -/* FIXME: fill this if needed. */ -} -`) - /* FIXME:XX Move this to ec/lenovo. */ smi := Create(ctx, "smihandler.c") defer smi.Close() diff --git a/util/autoport/readme.md b/util/autoport/readme.md index fa349b9..6d1c64c 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -407,9 +407,9 @@ `gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2` and all others are absent.
-If your dock has LPC wires or needs some special treatement you -need to fill `h8_mainboard_init_dock` and add support code to -DSDT. See the code for `x60`, `x200` or `x201` +If your dock has LPC wires or needs some special treatement you may +need to add codes to initialize the dock and support code to +DSDT. See the `init_dock()` for `x60`, `x200` or `x201`.
## EC (generic laptop)
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36752 )
Change subject: util/autoport: Stop generate empty h8_mainboard_init_dock(). ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36752/1/util/autoport/readme.md File util/autoport/readme.md:
https://review.coreboot.org/c/coreboot/+/36752/1/util/autoport/readme.md@411 PS1, Line 411: codes nit: code
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36752 )
Change subject: util/autoport: Stop generate empty h8_mainboard_init_dock(). ......................................................................
util/autoport: Stop generate empty h8_mainboard_init_dock().
CB:36385 makes dock init in ramstage fully mainboard-specific, so keeping generating empty h8_mainboard_init_dock() for lenovo EC becomes unnecessary and problematic.
Change-Id: I19f57f41403ffd0319cc86f21bec7e142095df83 Signed-off-by: Bill XIE persmule@hardenedlinux.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/36752 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M util/autoport/ec_lenovo.go M util/autoport/readme.md 2 files changed, 3 insertions(+), 17 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/util/autoport/ec_lenovo.go b/util/autoport/ec_lenovo.go index c2dd333..9384896 100644 --- a/util/autoport/ec_lenovo.go +++ b/util/autoport/ec_lenovo.go @@ -59,20 +59,6 @@
si.WriteString("#include <drivers/pc80/pc/ps2_controller.asl>\n")
- dock := Create(ctx, "dock.c") - defer dock.Close() - - AddRAMStageFile("dock.c", "") - - dock.WriteString( - `#include <ec/lenovo/h8/h8.h> - -void h8_mainboard_init_dock (void) -{ -/* FIXME: fill this if needed. */ -} -`) - /* FIXME:XX Move this to ec/lenovo. */ smi := Create(ctx, "smihandler.c") defer smi.Close() diff --git a/util/autoport/readme.md b/util/autoport/readme.md index fa349b9..6d1c64c 100644 --- a/util/autoport/readme.md +++ b/util/autoport/readme.md @@ -407,9 +407,9 @@ `gpi*_routing` matching `GPE_EC_WAKE` or `GPE_EC_SCI` is set to `2` and all others are absent.
-If your dock has LPC wires or needs some special treatement you -need to fill `h8_mainboard_init_dock` and add support code to -DSDT. See the code for `x60`, `x200` or `x201` +If your dock has LPC wires or needs some special treatement you may +need to add codes to initialize the dock and support code to +DSDT. See the `init_dock()` for `x60`, `x200` or `x201`.
## EC (generic laptop)
-
Bill XIE (Code Review) -
Patrick Georgi (Code Review)