Attention is currently required from: Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61685 )
Change subject: mb/google/reef: Add VBTs for all variants
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/reef/variants/coral/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/61685/comment/ad22fee6_3aba5e34
PS1, Line 14: $(call add_vbt_to_cbfs, vbt-santa.bin, santa-data.vbt)
It's *HAVE*_VBT that should be selected, right? AIUI, without guards, the user's […]
yes sorry, INTEL_GMA_HAVE_VBT is selected (and not user deselectable).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46ad4ec321e32d019e44f0741956b18a464fb8ae
Gerrit-Change-Number: 61685
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 08 Feb 2022 15:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment