Attention is currently required from: Hung-Te Lin, Paul Menzel, Jianjun Wang, Felix Held. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63190 )
Change subject: soc/mediatek: Fix function type and initialize structure to zero ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63190/comment/c6c99fd6_d96ef2d2 PS1, Line 7: soc/mediatek: Fix function type and initialize structure to zero soc/mediatek/early_init: Fix function return type
https://review.coreboot.org/c/coreboot/+/63190/comment/559807ca_8174aa6d PS1, Line 9: function type return type of early_init_get_elapsed_time_us()
https://review.coreboot.org/c/coreboot/+/63190/comment/438672b9_4b22a867 PS1, Line 9: , and : initialize structure to zero to replace memset. Move to a separate paragraph.
Also replace memset() with struct initializer.
File src/soc/mediatek/common/early_init.c:
https://review.coreboot.org/c/coreboot/+/63190/comment/a85e6ee9_ed494624 PS1, Line 34: early_init_get_elapsed_time_us What about the caller of this (perst_time_us and min_perst_time_us in soc/mediatek/common/pcie.c)?