Moritz Fischer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50888 )
Change subject: soc/rockchip/rk3399/sdram: Use rank_mask in WDQL training
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
How many ranks does that board have?
The config file(s) says 0x2 for rank on the 4G models. This should result in get_rank_mask() return 0x3 and should make the loop here do the same?
Could it be one of the other changes that went in (like the phy_ctrl_reset, or the clearing of the IRQ bits) or did you manage to bisect it to this commit? This change was supposed to be mostly a no-op for LPDDR3 case.
Very sorry about the breakage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50888
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bff9d20d3d66984c49073aa21212708039d578f
Gerrit-Change-Number: 50888
Gerrit-PatchSet: 9
Gerrit-Owner: Moritz Fischer
moritzf@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 24 Feb 2021 15:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment