Attention is currently required from: Keith Hui.
Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85797?usp=email )
Change subject: mb/asus/p8x7x-series: Streamline DT PCIe configs ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85797/comment/64b1b4ee_cc3f845f?usp... : PS2, Line 7: Streamline DT PCIe configs Maybe something like "Streamline devicetree configs" or "Clean up devicetree devices"? Yes, all the devices are logical PCI devices, but at least to me "PCIe configs" sounds more like something specific to the pcie_rp* devices.
File src/mainboard/asus/p8x7x-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85797/comment/44c88b7f_cb6cd62b?usp... : PS2, Line 35: device ref pci_bridge off end Can also be removed, defaults to off in chipset.cb
https://review.coreboot.org/c/coreboot/+/85797/comment/5ff7dae0_8d099685?usp... : PS2, Line 37: device ref sata2 off end # SATA (Legacy) Can also be removed, defaults to off in chipset.cb
-
Nicholas Chin (Code Review)