Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78179?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/rex: Fix ISH I2C pad for suspend ......................................................................
mb/google/rex: Fix ISH I2C pad for suspend
During suspend, the ISH I2C transactions cannot go through because the GPIO pads remain the pervious value. The IO Standby State (IOSSTATE) needs to be changed to keep I2C bus active and functional during suspend.
BUG=b:302612549 TEST=on Google/rex platform with ISH enabled, do suspend_stress_test and check that no i2c failure.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: I9a2c902ed56461f3a535428db399c2050756f2da Reviewed-on: https://review.coreboot.org/c/coreboot/+/78179 Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Li1 Feng li1.feng@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/rex/variants/rex0/fw_config.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: Li1 Feng: Looks good to me, but someone else must approve build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/rex/variants/rex0/fw_config.c b/src/mainboard/google/rex/variants/rex0/fw_config.c index 86cb781..cea55ec 100644 --- a/src/mainboard/google/rex/variants/rex0/fw_config.c +++ b/src/mainboard/google/rex/variants/rex0/fw_config.c @@ -85,9 +85,9 @@
static const struct pad_config ish_enable_pads[] = { /* GPP_B02 : ISH I2C0_SDA */ - PAD_CFG_NF(GPP_B02, NONE, DEEP, NF3), + PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B02, NONE, DEEP, NF3), /* GPP_B03 : ISH_I2C0_SCL */ - PAD_CFG_NF(GPP_B03, NONE, DEEP, NF3), + PAD_CFG_NF_IOSTANDBY_IGNORE(GPP_B03, NONE, DEEP, NF3), /* GPP_D05 : ISH_UART_TX */ PAD_CFG_NF(GPP_D05, NONE, DEEP, NF2), /* GPP_D06 : ISH_UART_RX */