Change in coreboot[master]: src/superio: drop Makefile.inc, instead use wildcard matches
Idwer Vollering has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48900 )
Change subject: src/superio: drop Makefile.inc, instead use wildcard matches ......................................................................
src/superio: drop Makefile.inc, instead use wildcard matches
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: If77d59485451c77dcea752bc4fe0dfadba8fec45 --- M Makefile.inc D src/superio/Makefile.inc A src/superio/common/Makefile.inc 3 files changed, 6 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/48900/1
diff --git a/Makefile.inc b/Makefile.inc index 1212dae..1cd8ae5 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -77,10 +77,10 @@
####################################################################### # root source directories of coreboot -subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi +subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi src/superio/common subdirs-y += src/ec/acpi $(wildcard src/ec/*/*) $(wildcard src/southbridge/*/*) subdirs-y += $(wildcard src/soc/*/*) $(wildcard src/northbridge/*/*) -subdirs-y += src/superio +subdirs-y += $(wildcard src/superio/*) $(wildcard src/superio/*/*) subdirs-y += $(wildcard src/drivers/*) $(wildcard src/drivers/*/*) $(wildcard src/drivers/*/*/*) subdirs-y += src/cpu src/vendorcode subdirs-y += util/cbfstool util/sconfig util/nvramtool util/pgtblgen util/amdfwtool diff --git a/src/superio/Makefile.inc b/src/superio/Makefile.inc deleted file mode 100644 index e874f34..0000000 --- a/src/superio/Makefile.inc +++ /dev/null @@ -1,14 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only - -subdirs-y += aspeed -subdirs-y += fintek -subdirs-y += ite -subdirs-y += nsc -subdirs-y += nuvoton -subdirs-y += renesas -subdirs-y += serverengines -subdirs-y += smsc -subdirs-y += winbond - -ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += common/conf_mode.c -ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_64) += common/conf_mode.c diff --git a/src/superio/common/Makefile.inc b/src/superio/common/Makefile.inc new file mode 100644 index 0000000..46103c6 --- /dev/null +++ b/src/superio/common/Makefile.inc @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only + +ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += conf_mode.c +ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_64) += conf_mode.c
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48900 )
Change subject: src/superio: drop Makefile.inc, instead use wildcard matches ......................................................................
Patch Set 2: Code-Review+2
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Arthur Heymans, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48900
to look at the new patch set (#3).
Change subject: src/superio: trim and move Makefile.inc, instead use wildcard matches ......................................................................
src/superio: trim and move Makefile.inc, instead use wildcard matches
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: If77d59485451c77dcea752bc4fe0dfadba8fec45 --- M Makefile.inc D src/superio/Makefile.inc A src/superio/common/Makefile.inc 3 files changed, 6 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/48900/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48900 )
Change subject: src/superio: trim and move Makefile.inc, instead use wildcard matches ......................................................................
Patch Set 3: Code-Review+2
Idwer Vollering has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48900 )
Change subject: src/superio: trim and move Makefile.inc, instead use wildcard matches ......................................................................
src/superio: trim and move Makefile.inc, instead use wildcard matches
Signed-off-by: Idwer Vollering vidwer@gmail.com Change-Id: If77d59485451c77dcea752bc4fe0dfadba8fec45 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48900 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc D src/superio/Makefile.inc A src/superio/common/Makefile.inc 3 files changed, 6 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 2b9d58d..bacddf2 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -77,10 +77,10 @@
####################################################################### # root source directories of coreboot -subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi +subdirs-y := src/lib src/commonlib/ src/console src/device src/acpi src/superio/common subdirs-y += src/ec/acpi $(wildcard src/ec/*/*) $(wildcard src/southbridge/*/*) subdirs-y += $(wildcard src/soc/*/*) $(wildcard src/northbridge/*/*) -subdirs-y += src/superio +subdirs-y += $(wildcard src/superio/*) $(wildcard src/superio/*/*) subdirs-y += $(wildcard src/drivers/*) $(wildcard src/drivers/*/*) $(wildcard src/drivers/*/*/*) subdirs-y += src/cpu src/vendorcode subdirs-y += util/cbfstool util/sconfig util/nvramtool util/pgtblgen util/amdfwtool diff --git a/src/superio/Makefile.inc b/src/superio/Makefile.inc deleted file mode 100644 index e874f34..0000000 --- a/src/superio/Makefile.inc +++ /dev/null @@ -1,14 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only - -subdirs-y += aspeed -subdirs-y += fintek -subdirs-y += ite -subdirs-y += nsc -subdirs-y += nuvoton -subdirs-y += renesas -subdirs-y += serverengines -subdirs-y += smsc -subdirs-y += winbond - -ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += common/conf_mode.c -ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_64) += common/conf_mode.c diff --git a/src/superio/common/Makefile.inc b/src/superio/common/Makefile.inc new file mode 100644 index 0000000..46103c6 --- /dev/null +++ b/src/superio/common/Makefile.inc @@ -0,0 +1,4 @@ +# SPDX-License-Identifier: GPL-2.0-only + +ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_32) += conf_mode.c +ramstage-$(CONFIG_ARCH_RAMSTAGE_X86_64) += conf_mode.c
-
Arthur Heymans (Code Review) -
Felix Held (Code Review)
-
Idwer Vollering (Code Review)