Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52917 )
Change subject: soc/amd/common/block/pci: Implement acpigen_write_pci_{GNB,FCH}_PRT
......................................................................
Patch Set 6:
(3 comments)
Patchset:
PS6:
rest looks good for me
File src/soc/amd/common/block/pci/acpi_prt.c:
https://review.coreboot.org/c/coreboot/+/52917/comment/31fb9278_a9b9cfa9
PS6, Line 98: LNKA
is this correct? from the code above, i'd assume to rather be \_SB.INTA
https://review.coreboot.org/c/coreboot/+/52917/comment/fc1532f4_42b64c21
PS6, Line 167: LNKA
same here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I926430074acb969ceb11fdb60ab56dcf91ac4c76
Gerrit-Change-Number: 52917
Gerrit-PatchSet: 6
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Sat, 08 May 2021 01:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment