Attention is currently required from: Nico Huber, Subrata Banik, Dinesh Gehlot, Paul Menzel, Lean Sheng Tan.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74511 )
Change subject: soc/intel/common: Don't hardcode ramtop offset
......................................................................
Patch Set 17:
(3 comments)
Patchset:
PS7:
Boot verified the changes on Rex(MTL) […]
Can I mark as resolved?
File src/soc/intel/common/basecode/ramtop/ramtop.c:
https://review.coreboot.org/c/coreboot/+/74511/comment/3719f839_4016728f
PS14, Line 22: #if CMOS_VSTART_ramtop % 8 != 0
Please mention this in the commit message?
Done
https://review.coreboot.org/c/coreboot/+/74511/comment/f1a9fefd_a51980d3
PS14, Line 24: ==
!=
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74511
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5327b5d4e78b715a85072e5d9a62cf8fd2ae92c0
Gerrit-Change-Number: 74511
Gerrit-PatchSet: 17
Gerrit-Owner: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dinesh Gehlot
digehlot@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Wed, 10 May 2023 14:37:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes
sean@starlabs.systems
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment