Attention is currently required from: Intel coreboot Reviewers, Martin L Roth, Paul Menzel, Ronak Kanabar, Shuo Liu.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/83738?usp=email )
Change subject: vendorcode/intel: allow selecting EDK headers manually ......................................................................
Patch Set 13:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83738/comment/cf2486f4_6884c578?usp... : PS3, Line 7: vendorcode/intel
Should it be generalized in the future?
It could be, but it needs to be untied from FSP-related code. Headers in `src/vendorcode/intel/edk2` need to be moved somewhere (without `IntelFsp2Pkg` directory). There seems to be no good place for that, maybe something like `src/uefi` or `src/vendor/uefi`. The headers are used by AMD boards, by the way, so it's more of a vendor-supplied/managed rather than vendor-specific functionality.
File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/83738/comment/07556a5f_caff55e9?usp... : PS13, Line 63: select UDK_BASE
To support these EFI drivers, can the codes simply assign a default UDK binding if no default? (P.S. […]
As long as `UDK_BASE` is selected, the drivers will be enabled. Alternatives:
* making `UDK_BASE` selectable * making drivers depend on `EDK_BASE || PAYLOAD_EDK2` * always enabling `UDK_BASE` for `PAYLOAD_EDK2` (what you seem to suggest)
Allowing picking a version just seemed like a more generic solution applicable to more use cases. But I'm not attached to any specific approach and happy to use a different one if it makes more sense to you.
-
Sergii Dmytruk (Code Review)