Attention is currently required from: Benjamin Doron, Lean Sheng Tan.
Julius Werner has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/85643?usp=email )
Change subject: commonlib/device_tree.c: Add a function that reads FDT ints ......................................................................
Patch Set 5: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85643/comment/5b18fc62_a597e002?usp... : PS5, Line 13: / typo
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85643/comment/2ef119c5_0c06b5a9?usp... : PS5, Line 266: printk(BIOS_ERR, "FDT integer property of size %u @%p doesn't match expected cell count %u\n", prop->size, prop->data, cells); Should at least drop the arguments after the format string into a continuation line.