Change in coreboot[master]: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45910 )
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64 ......................................................................
mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64
Change-Id: I96d3f01094cc281d76ffbc9bc4bae1bbf37ffa70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/opencellular/elgon/mainboard.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45910/1
diff --git a/src/mainboard/opencellular/elgon/mainboard.c b/src/mainboard/opencellular/elgon/mainboard.c index f9dc03c..6e9bba3 100644 --- a/src/mainboard/opencellular/elgon/mainboard.c +++ b/src/mainboard/opencellular/elgon/mainboard.c @@ -17,6 +17,7 @@ #include <soc/spi.h> #include <spi_flash.h> #include <fmap.h> +#include <inttypes.h>
static void mainboard_print_info(void) { @@ -61,13 +62,13 @@ printk(BIOS_INFO, "unknown\n"); }
- printk(BIOS_INFO, "MB: REFclk : %llu MHz\n", + printk(BIOS_INFO, "MB: REFclk : %"PRIu64 " MHz\n", thunderx_get_ref_clock() / 1000000ULL);
- printk(BIOS_INFO, "MB: IOclk : %llu MHz\n", + printk(BIOS_INFO, "MB: IOclk : %"PRIu64 " MHz\n", thunderx_get_io_clock() / 1000000ULL);
- printk(BIOS_INFO, "MB: COREclk : %llu MHz\n", + printk(BIOS_INFO, "MB: COREclk : %"PRIu64 " MHz\n", thunderx_get_core_clock() / 1000000ULL);
printk(BIOS_INFO, "MB: #CPU cores : %zu\n", @@ -76,7 +77,7 @@ printk(BIOS_INFO, "MB: RAM : %zu MiB\n", sdram_size_mb());
- printk(BIOS_INFO, "MB: SPIclk : %llu kHz\n", + printk(BIOS_INFO, "MB: SPIclk : %"PRIu64 " kHz\n", spi_get_clock(0) >> 10); }
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45910 )
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64 ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/... File src/mainboard/opencellular/elgon/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/... PS1, Line 65: printk(BIOS_INFO, "MB: REFclk : %"PRIu64 " MHz\n", i'd add a space between the first part of the format string and the PRIu64
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45910 )
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64 ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/... File src/mainboard/opencellular/elgon/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45910/1/src/mainboard/opencellular/... PS1, Line 65: printk(BIOS_INFO, "MB: REFclk : %"PRIu64 " MHz\n",
i'd add a space between the first part of the format string and the PRIu64
Thank you.
Hello build bot (Jenkins), Patrick Rudolph, Christian Walter, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45910
to look at the new patch set (#2).
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64 ......................................................................
mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64
Change-Id: I96d3f01094cc281d76ffbc9bc4bae1bbf37ffa70 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/opencellular/elgon/mainboard.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/45910/2
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45910 )
Change subject: mb/opencellular/elgon/mainboard.c: Use PRIu64 type to print u64 ......................................................................
Patch Set 2:
Please give the reason why it was changed in the commit message.
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Rudolph (Code Review)