Attention is currently required from: Patrick Rudolph. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/51712 )
Change subject: soc/intel/alderlake: Remove usage of '&' while memcpy ......................................................................
soc/intel/alderlake: Remove usage of '&' while memcpy
This patch ensures memcpy is copying the required value into RcompResistor and RcompTarget array.
Change-Id: I66e6b645c19bbd83f94830eb72516fcbab98e2cb Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/soc/intel/alderlake/meminit.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/51712/1
diff --git a/src/soc/intel/alderlake/meminit.c b/src/soc/intel/alderlake/meminit.c index 5b65ef0..b88cf62 100644 --- a/src/soc/intel/alderlake/meminit.c +++ b/src/soc/intel/alderlake/meminit.c @@ -28,9 +28,9 @@ static void meminit_ddr(FSP_M_CONFIG *mem_cfg, const struct mem_ddr_config *ddr_config) { mem_cfg->DqPinsInterleaved = ddr_config->dq_pins_interleaved; - memcpy(&mem_cfg->RcompResistor, ddr_config->rcomp_resistor, + memcpy(mem_cfg->RcompResistor, ddr_config->rcomp_resistor, sizeof(mem_cfg->RcompResistor)); - memcpy(&mem_cfg->RcompTarget, ddr_config->rcomp_targets, sizeof(mem_cfg->RcompTarget)); + memcpy(mem_cfg->RcompTarget, ddr_config->rcomp_targets, sizeof(mem_cfg->RcompTarget)); }
static const struct soc_mem_cfg soc_mem_cfg[] = {