Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35508 )
Change subject: HACK trogdor: SoC makefile BLOB support HACK
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma...
File src/soc/qualcomm/sc7180/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35508/15/src/soc/qualcomm/sc7180/Ma...
PS15, Line 102: DCB_FILE := $(SC7180_BLOB)/600E_0100_1_1_dcb.bin
Can we just call this thing dcb.bin? It's stupid if we have to change the Makefile every time the version changes, and it makes it easy to accidentally build a broken image (because this will silently build without the file if it's named slightly differently).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35508
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85a20ef31ec91c6f22221d16fd4c3097c5cb97d1
Gerrit-Change-Number: 35508
Gerrit-PatchSet: 15
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: ashk@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 08 Nov 2019 22:25:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment