Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46690 )
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
nb/intel/haswell/gma.c: Move log message to the right place
The message was being printed too early, possibly because it was relocated around alongside the rest of the code.
Change-Id: I4257f6f0baa1c398aa1df9bd3274458abfaf28a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/46690/1
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 2368e7b..dc7b629 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -290,8 +290,6 @@ struct northbridge_intel_haswell_config *conf = config_of(dev); u32 reg32;
- printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n"); - /* Setup Digital Port Hotplug */ reg32 = gtt_read(PCH_PORT_HOTPLUG); if (!reg32) { @@ -493,7 +491,8 @@ pci_dev_init(dev); }
- /* Post panel init */ + printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n"); + gma_pm_init_post_vbios(dev);
gma_enable_swsci();
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46690 )
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46690
to look at the new patch set (#4).
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
nb/intel/haswell/gma.c: Move log message to the right place
The message was being printed too early, possibly because it was relocated around alongside the rest of the code.
Change-Id: I4257f6f0baa1c398aa1df9bd3274458abfaf28a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/46690/4
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46690
to look at the new patch set (#5).
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
nb/intel/haswell/gma.c: Move log message to the right place
The message was being printed too early, possibly because it was relocated around alongside the rest of the code.
Change-Id: I4257f6f0baa1c398aa1df9bd3274458abfaf28a6 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/haswell/gma.c 1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/46690/5
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46690 )
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46690 )
Change subject: nb/intel/haswell/gma.c: Move log message to the right place ......................................................................
nb/intel/haswell/gma.c: Move log message to the right place
The message was being printed too early, possibly because it was relocated around alongside the rest of the code.
Change-Id: I4257f6f0baa1c398aa1df9bd3274458abfaf28a6 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46690 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Patrick Rudolph siro@das-labor.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/haswell/gma.c 1 file changed, 2 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Michael Niewöhner: Looks good to me, approved
diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index 2368e7b..dc7b629 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -290,8 +290,6 @@ struct northbridge_intel_haswell_config *conf = config_of(dev); u32 reg32;
- printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n"); - /* Setup Digital Port Hotplug */ reg32 = gtt_read(PCH_PORT_HOTPLUG); if (!reg32) { @@ -493,7 +491,8 @@ pci_dev_init(dev); }
- /* Post panel init */ + printk(BIOS_DEBUG, "GT Power Management Init (post VBIOS)\n"); + gma_pm_init_post_vbios(dev);
gma_enable_swsci();
-
Angel Pons (Code Review) -
Michael Niewöhner (Code Review)
-
Patrick Rudolph (Code Review)