Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/59631 )
Change subject: soc/amd/common/block/include/gpio_defs: add missing de-glitching defines ......................................................................
soc/amd/common/block/include/gpio_defs: add missing de-glitching defines
There were only definitions for removing low, high or both glitches, but not to not remove glitches, so add this too for completeness.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I650f7754546935539339c02bb6a94bb3f855d4ce Reviewed-on: https://review.coreboot.org/c/coreboot/+/59631 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/soc/amd/common/block/include/amdblocks/gpio_defs.h 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h index 1e3b172..187be51 100644 --- a/src/soc/amd/common/block/include/amdblocks/gpio_defs.h +++ b/src/soc/amd/common/block/include/amdblocks/gpio_defs.h @@ -103,9 +103,11 @@ #define GPIO_FLAG_EVENT_TRIGGER_EDGE_LOW (GPIO_FLAG_EVENT_TRIGGER_EDGE | \ GPIO_FLAG_EVENT_ACTIVE_LOW) #define DEB_GLITCH_SHIFT 5 +#define DEB_GLITCH_NO_DEBOUNCE 0 #define DEB_GLITCH_LOW 1 #define DEB_GLITCH_HIGH 2 #define DEB_GLITCH_REMOVE 3 +#define GPIO_DEB_PRESERVE_GLITCH (DEB_GLITCH_NO_DEBOUNCE << DEB_GLITCH_SHIFT) #define GPIO_DEB_PRESERVE_LOW_GLITCH (DEB_GLITCH_LOW << DEB_GLITCH_SHIFT) #define GPIO_DEB_PRESERVE_HIGH_GLITCH (DEB_GLITCH_HIGH << DEB_GLITCH_SHIFT) #define GPIO_DEB_REMOVE_GLITCH (DEB_GLITCH_REMOVE << DEB_GLITCH_SHIFT)