Change in coreboot[master]: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake
Franklin (Yanjin) He has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39579 )
Change subject: soc/intel/apollolake: Allow toggling of GMM in devicetree in Gemini Lake ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... PS1, Line 635: // Enables or disables GMM in devicetree
The comment is not needed, as the code is obvious.
Done
https://review.coreboot.org/c/coreboot/+/39579/1/src/soc/intel/apollolake/ch... PS1, Line 637: silconfig->Gmm = dev ? dev->enabled : 0;
Is it required on all the GLK devices or is it required for select variants? […]
The device is integrated on the SoC for all gemini lake CPUs so we are hoping to enable it for all variants of Gemini Lake designs. At least that is the message from Intel.
-
Franklin (Yanjin) He (Code Review)