Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29819 )
Change subject: soc/fsp_broadwell_de: Add early microcode updates
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/29819/3/src/drivers/intel/fsp1_0/fsp_util.c
File src/drivers/intel/fsp1_0/fsp_util.c:
https://review.coreboot.org/#/c/29819/3/src/drivers/intel/fsp1_0/fsp_util.c@...
PS3, Line 81: intel_update_microcode_from_cbfs
Are you sure this works at this point? On older Intel hardware updating microcode while running in C […]
Tried it, boots and updates the microcode.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie31acaf0fc41c51b9edf65b981d43d7732661770
Gerrit-Change-Number: 29819
Gerrit-PatchSet: 3
Gerrit-Owner: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: York Yang
york.yang@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 27 Nov 2018 11:31:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment