Attention is currently required from: Furquan Shaikh, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55675 )
Change subject: soc/intel/common/block/cse: Add BWG error recovery to EOP failure
......................................................................
Patch Set 14:
(1 comment)
File src/soc/intel/common/block/cse/cse_eop.c:
https://review.coreboot.org/c/coreboot/+/55675/comment/8073b729_9ffc3982
PS14, Line 152: config_t *config = config_of_soc();
: config->HeciEnabled = 0;
Umm.. This isn't really gonna work. […]
Oh you're right, and we're well past setting SMM by this point too. I think this disable bus then disable device dance might be the best we can really do.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06abf36a9d9d8a5f2afba6002dd5695dd2107db1
Gerrit-Change-Number: 55675
Gerrit-PatchSet: 14
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 30 Jun 2021 19:38:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment