Change in coreboot[master]: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts
Tao Xia has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
mb/google/dedede/var/storo: Generate SPD ID for supported memory parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the memory parts. The memory parts being added are: MT53E512M32D2NP-046 WT:E H9HCNNNBKMMLXR-NEE MT53E1G32D2NP-046 WT:A H9HCNNNCPMMLXR-NEE
BUG=None TEST=Build the storo board.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Ifd935865927bb9fccf95eb4924ca6986d0c19442 --- M src/mainboard/google/dedede/variants/storo/memory/Makefile.inc M src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt 3 files changed, 12 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/48447/1
diff --git a/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc b/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc index b0ca222..c0e2fff 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt index fa24790..ad6374d 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +H9HCNNNCPMMLXR-NEE 2 (0010) diff --git a/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt index 59381dc..43363e7 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt @@ -1,6 +1,4 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +H9HCNNNBKMMLXR-NEE +MT53E1G32D2NP-046 WT:A +H9HCNNNCPMMLXR-NEE
Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
Patch Set 1: Code-Review+1
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
Patch Set 1:
Please help do code review.Thank you.
Xuxin Xiong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
Patch Set 1: Code-Review+1
Tao Xia has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
Patch Set 1:
Please help do code review.Thank you.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
Patch Set 1: Code-Review+2
Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48447 )
Change subject: mb/google/dedede/var/storo: Generate SPD ID for supported memory parts ......................................................................
mb/google/dedede/var/storo: Generate SPD ID for supported memory parts
Add supported memory parts in the mem_parts_used.txt and generate the SPD ID for the memory parts. The memory parts being added are: MT53E512M32D2NP-046 WT:E H9HCNNNBKMMLXR-NEE MT53E1G32D2NP-046 WT:A H9HCNNNCPMMLXR-NEE
BUG=None TEST=Build the storo board.
Signed-off-by: Tao Xia xiatao5@huaqin.corp-partner.google.com Change-Id: Ifd935865927bb9fccf95eb4924ca6986d0c19442 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48447 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Fagerburg pfagerburg@chromium.org Reviewed-by: Xuxin Xiong xuxinxiong@huaqin.corp-partner.google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com --- M src/mainboard/google/dedede/variants/storo/memory/Makefile.inc M src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt 3 files changed, 12 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Karthik Ramasubramanian: Looks good to me, approved Paul Fagerburg: Looks good to me, but someone else must approve Xuxin Xiong: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc b/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc index b0ca222..c0e2fff 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/storo/memory/Makefile.inc @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later ## This is an auto-generated file. Do not edit!! -## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate.
-SPD_SOURCES = placeholder.spd.hex +SPD_SOURCES = +SPD_SOURCES += lp4x-spd-1.hex # ID = 0(0b0000) Parts = MT53E512M32D2NP-046 WT:E, H9HCNNNBKMMLXR-NEE +SPD_SOURCES += lp4x-spd-4.hex # ID = 1(0b0001) Parts = MT53E1G32D2NP-046 WT:A +SPD_SOURCES += lp4x-spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE diff --git a/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt index fa24790..ad6374d 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/storo/memory/dram_id.generated.txt @@ -1 +1,5 @@ DRAM Part Name ID to assign +MT53E512M32D2NP-046 WT:E 0 (0000) +H9HCNNNBKMMLXR-NEE 0 (0000) +MT53E1G32D2NP-046 WT:A 1 (0001) +H9HCNNNCPMMLXR-NEE 2 (0010) diff --git a/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt index 59381dc..43363e7 100644 --- a/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/storo/memory/mem_parts_used.txt @@ -1,6 +1,4 @@ -# This is a CSV file containing a list of memory parts used by this variant. -# Generate an updated Makefile.inc and dram_id.generated.txt by running the -# gen_part_id tool from util/spd_tools/lp4x -# See util/spd_tools/lp4x/README.md for more details and instructions. - -# Part Name +MT53E512M32D2NP-046 WT:E +H9HCNNNBKMMLXR-NEE +MT53E1G32D2NP-046 WT:A +H9HCNNNCPMMLXR-NEE
-
Hung-Te Lin (Code Review) -
Karthik Ramasubramanian (Code Review)
-
Paul Fagerburg (Code Review)
-
Tao Xia (Code Review)
-
Xuxin Xiong (Code Review)