Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Tim Wawrzynczak.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80169?usp=email )
Change subject: device: Add inline method to identify PATH_ROOT
......................................................................
Patch Set 1:
(1 comment)
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/80169/comment/a035595f_396ebf1b :
PS1, Line 166: extern DEVTREE_CONST struct device dev_root;
Would comparing pointers with this not be a better idea? I suppose the compiler might even be able t […]
I don't see how the compiler could optimize something. I'd expect is_root_device() to be never called directly on the root device itself as this is rather pointless check. For all other devices it shouldn't matter if the pointer or the actual type is read and compared.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80169?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I394c8668245bcfea6414b8ca5f14ef8135897e59
Gerrit-Change-Number: 80169
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 23 Jan 2024 08:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment