Attention is currently required from: Arthur Heymans, Cliff Huang, Lance Zhao, Tim Wawrzynczak.

View Change

1 comment:

• File src/include/device/device.h:

  • Patch Set #1, Line 166: extern DEVTREE_CONST struct device dev_root;

    Would comparing pointers with this not be a better idea? I suppose the compiler might even be able t […]

    I don't see how the compiler could optimize something. I'd expect is_root_device() to be never called directly on the root device itself as this is rather pointless check. For all other devices it shouldn't matter if the pointer or the actual type is read and compared.

To view, visit change 80169. To unsubscribe, or for help writing mail filters, visit settings.