Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52913 )
Change subject: soc/amd/common/fsp/pci: Implement populate_pirq_data
......................................................................
Patch Set 3:
(2 comments)
File src/soc/amd/common/fsp/pci/pirq.c:
https://review.coreboot.org/c/coreboot/+/52913/comment/8336a5ed_c16cb149
PS3, Line 19:
might be a good idea to check if entries is != 0 before calling calloc
https://review.coreboot.org/c/coreboot/+/52913/comment/01650d38_4bd9cfaa
PS3, Line 23: return;
add some BIOS_ERR printk here? for a valid routing table calloc isn't supposed to return NULL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I297fc3ca7227fb4794ac70bd046ce2f93da8b869
Gerrit-Change-Number: 52913
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Thu, 06 May 2021 23:24:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment