Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46886 )
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/cpu/haswell.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46886/1
diff --git a/src/soc/intel/broadwell/cpu/cpu.c b/src/soc/intel/broadwell/cpu/cpu.c index 9348439..10db364 100644 --- a/src/soc/intel/broadwell/cpu/cpu.c +++ b/src/soc/intel/broadwell/cpu/cpu.c @@ -614,10 +614,8 @@ .post_mp_init = post_mp_init, };
-void broadwell_init_cpus(struct device *dev) +void mp_init_cpus(struct bus *cpu_bus) { - struct bus *cpu_bus = dev->link_list; - if (mp_init_with_smm(cpu_bus, &mp_ops)) printk(BIOS_ERR, "MP initialization failure.\n"); } diff --git a/src/soc/intel/broadwell/cpu/haswell.h b/src/soc/intel/broadwell/cpu/haswell.h index 399fc23..26077a7 100644 --- a/src/soc/intel/broadwell/cpu/haswell.h +++ b/src/soc/intel/broadwell/cpu/haswell.h @@ -120,8 +120,6 @@ void set_power_limits(u8 power_limit_1_time); int cpu_config_tdp_levels(void);
-void broadwell_init_cpus(struct device *dev); - void set_max_freq(void);
/* CPU identification */ diff --git a/src/soc/intel/broadwell/northbridge.c b/src/soc/intel/broadwell/northbridge.c index 980be4d..73c6e83 100644 --- a/src/soc/intel/broadwell/northbridge.c +++ b/src/soc/intel/broadwell/northbridge.c @@ -461,7 +461,7 @@ static struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, - .init = &broadwell_init_cpus, + .init = &mp_cpu_bus_init, };
static void broadwell_enable(struct device *dev)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46886
to look at the new patch set (#7).
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/cpu/haswell.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46886/7
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46886
to look at the new patch set (#9).
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
This is needed to allow switching to Haswell CPU code in the future.
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/include/soc/ramstage.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46886/9
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46886
to look at the new patch set (#13).
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
This is needed to allow switching to Haswell CPU code in the future.
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/include/soc/ramstage.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/46886/13
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46886 )
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
Patch Set 14: Code-Review+2
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46886 )
Change subject: soc/intel/broadwell: Use `mp_cpu_bus_init` ......................................................................
soc/intel/broadwell: Use `mp_cpu_bus_init`
This is needed to allow switching to Haswell CPU code in the future.
Change-Id: Ic642f32f9c4a269a66ac470b7a7217f20ff8bfba Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46886 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/cpu/cpu.c M src/soc/intel/broadwell/include/soc/ramstage.h M src/soc/intel/broadwell/northbridge.c 3 files changed, 2 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/cpu/cpu.c b/src/soc/intel/broadwell/cpu/cpu.c index 72efa3d..7005c4b 100644 --- a/src/soc/intel/broadwell/cpu/cpu.c +++ b/src/soc/intel/broadwell/cpu/cpu.c @@ -616,10 +616,8 @@ .post_mp_init = post_mp_init, };
-void broadwell_init_cpus(struct device *dev) +void mp_init_cpus(struct bus *cpu_bus) { - struct bus *cpu_bus = dev->link_list; - if (mp_init_with_smm(cpu_bus, &mp_ops)) printk(BIOS_ERR, "MP initialization failure.\n"); } diff --git a/src/soc/intel/broadwell/include/soc/ramstage.h b/src/soc/intel/broadwell/include/soc/ramstage.h index 5d7eceb..4d057ac 100644 --- a/src/soc/intel/broadwell/include/soc/ramstage.h +++ b/src/soc/intel/broadwell/include/soc/ramstage.h @@ -7,7 +7,6 @@ #include <soc/intel/broadwell/chip.h>
void broadwell_init_pre_device(void *chip_info); -void broadwell_init_cpus(struct device *dev);
#if CONFIG(HAVE_REFCODE_BLOB) void broadwell_run_reference_code(void); diff --git a/src/soc/intel/broadwell/northbridge.c b/src/soc/intel/broadwell/northbridge.c index 5f7d43b..e2b84b3 100644 --- a/src/soc/intel/broadwell/northbridge.c +++ b/src/soc/intel/broadwell/northbridge.c @@ -461,7 +461,7 @@ static struct device_operations cpu_bus_ops = { .read_resources = noop_read_resources, .set_resources = noop_set_resources, - .init = &broadwell_init_cpus, + .init = mp_cpu_bus_init, };
static void broadwell_enable(struct device *dev)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)