Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49198 )
Change subject: mb/google/parrot: Fix spacing issues ......................................................................
mb/google/parrot: Fix spacing issues
Add a space after each comma to fix linter issues.
Change-Id: I5533c4fc7aa0e986da4350ec56b84903b3111a07 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/parrot/early_init.c M src/mainboard/google/parrot/ec.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/49198/1
diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c index f0ffc9f..b7ed73c 100644 --- a/src/mainboard/google/parrot/early_init.c +++ b/src/mainboard/google/parrot/early_init.c @@ -68,7 +68,7 @@ .thermalbase = 0xfed08000, .system_type = 0, // 0 Mobile, 1 Desktop/Server .tseg_size = CONFIG_SMM_TSEG_SIZE, - .spd_addresses = { 0xA0, 0x00,0xA4,0x00 }, + .spd_addresses = { 0xA0, 0x00, 0xA4, 0x00 }, .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, .ec_present = 1, // 0 = leave channel enabled diff --git a/src/mainboard/google/parrot/ec.c b/src/mainboard/google/parrot/ec.c index 3aa58c3..f4187eb 100644 --- a/src/mainboard/google/parrot/ec.c +++ b/src/mainboard/google/parrot/ec.c @@ -17,18 +17,18 @@ /* Report EC info */ /* EC version: cmd 0x51 - returns three bytes */ ec_kbc_write_cmd(0x51); - printk(BIOS_DEBUG," EC version %x.%x.%x\n", + printk(BIOS_DEBUG, " EC version %x.%x.%x\n", ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob());
/* EC Project name: cmd 0x52, 0xA0 - returns five bytes */ ec_kbc_write_cmd(0x52); ec_kbc_write_ib(0xA0); - printk(BIOS_DEBUG," EC Project: %c%c%c%c%c\n", - ec_kbc_read_ob(),ec_kbc_read_ob(),ec_kbc_read_ob(), + printk(BIOS_DEBUG, " EC Project: %c%c%c%c%c\n", + ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob());
/* Print the hardware revision */ - printk(BIOS_DEBUG," Parrot Revision %x\n", parrot_rev()); + printk(BIOS_DEBUG, " Parrot Revision %x\n", parrot_rev());
/* US Keyboard */ ec_kbc_write_cmd(0x59);
Attention is currently required from: Felix Singer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49198 )
Change subject: mb/google/parrot: Fix spacing issues ......................................................................
Patch Set 1: Code-Review+2
Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/49198
to look at the new patch set (#5).
Change subject: mb/google/parrot: Fix spacing issues ......................................................................
mb/google/parrot: Fix spacing issues
Add a space after each comma to fix linter issues.
Change-Id: I5533c4fc7aa0e986da4350ec56b84903b3111a07 Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/google/parrot/early_init.c M src/mainboard/google/parrot/ec.c 2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/49198/5
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49198 )
Change subject: mb/google/parrot: Fix spacing issues ......................................................................
mb/google/parrot: Fix spacing issues
Add a space after each comma to fix linter issues.
Change-Id: I5533c4fc7aa0e986da4350ec56b84903b3111a07 Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49198 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/parrot/early_init.c M src/mainboard/google/parrot/ec.c 2 files changed, 5 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c index f0ffc9f..b7ed73c 100644 --- a/src/mainboard/google/parrot/early_init.c +++ b/src/mainboard/google/parrot/early_init.c @@ -68,7 +68,7 @@ .thermalbase = 0xfed08000, .system_type = 0, // 0 Mobile, 1 Desktop/Server .tseg_size = CONFIG_SMM_TSEG_SIZE, - .spd_addresses = { 0xA0, 0x00,0xA4,0x00 }, + .spd_addresses = { 0xA0, 0x00, 0xA4, 0x00 }, .ts_addresses = { 0x00, 0x00, 0x00, 0x00 }, .ec_present = 1, // 0 = leave channel enabled diff --git a/src/mainboard/google/parrot/ec.c b/src/mainboard/google/parrot/ec.c index 3aa58c3..f4187eb 100644 --- a/src/mainboard/google/parrot/ec.c +++ b/src/mainboard/google/parrot/ec.c @@ -17,18 +17,18 @@ /* Report EC info */ /* EC version: cmd 0x51 - returns three bytes */ ec_kbc_write_cmd(0x51); - printk(BIOS_DEBUG," EC version %x.%x.%x\n", + printk(BIOS_DEBUG, " EC version %x.%x.%x\n", ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob());
/* EC Project name: cmd 0x52, 0xA0 - returns five bytes */ ec_kbc_write_cmd(0x52); ec_kbc_write_ib(0xA0); - printk(BIOS_DEBUG," EC Project: %c%c%c%c%c\n", - ec_kbc_read_ob(),ec_kbc_read_ob(),ec_kbc_read_ob(), + printk(BIOS_DEBUG, " EC Project: %c%c%c%c%c\n", + ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob());
/* Print the hardware revision */ - printk(BIOS_DEBUG," Parrot Revision %x\n", parrot_rev()); + printk(BIOS_DEBUG, " Parrot Revision %x\n", parrot_rev());
/* US Keyboard */ ec_kbc_write_cmd(0x59);
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49198 )
Change subject: mb/google/parrot: Fix spacing issues ......................................................................
Patch Set 6:
Automatic boot test returned (PASS/FAIL/TOTAL): 6/2/8 "ThinkPad T500" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/35644 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : FAIL : https://lava.9esec.io/r/35643 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/35642 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/35641 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/35640 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/35639 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/35637 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/35636
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Felix Singer (Code Review)
-
Nico Huber (Code Review)