Nico Huber submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
mb/google/parrot: Fix spacing issues

Add a space after each comma to fix linter issues.

Change-Id: I5533c4fc7aa0e986da4350ec56b84903b3111a07
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/49198
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
---
M src/mainboard/google/parrot/early_init.c
M src/mainboard/google/parrot/ec.c
2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/parrot/early_init.c b/src/mainboard/google/parrot/early_init.c
index f0ffc9f..b7ed73c 100644
--- a/src/mainboard/google/parrot/early_init.c
+++ b/src/mainboard/google/parrot/early_init.c
@@ -68,7 +68,7 @@
.thermalbase = 0xfed08000,
.system_type = 0, // 0 Mobile, 1 Desktop/Server
.tseg_size = CONFIG_SMM_TSEG_SIZE,
- .spd_addresses = { 0xA0, 0x00,0xA4,0x00 },
+ .spd_addresses = { 0xA0, 0x00, 0xA4, 0x00 },
.ts_addresses = { 0x00, 0x00, 0x00, 0x00 },
.ec_present = 1,
// 0 = leave channel enabled
diff --git a/src/mainboard/google/parrot/ec.c b/src/mainboard/google/parrot/ec.c
index 3aa58c3..f4187eb 100644
--- a/src/mainboard/google/parrot/ec.c
+++ b/src/mainboard/google/parrot/ec.c
@@ -17,18 +17,18 @@
/* Report EC info */
/* EC version: cmd 0x51 - returns three bytes */
ec_kbc_write_cmd(0x51);
- printk(BIOS_DEBUG," EC version %x.%x.%x\n",
+ printk(BIOS_DEBUG, " EC version %x.%x.%x\n",
ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob());

/* EC Project name: cmd 0x52, 0xA0 - returns five bytes */
ec_kbc_write_cmd(0x52);
ec_kbc_write_ib(0xA0);
- printk(BIOS_DEBUG," EC Project: %c%c%c%c%c\n",
- ec_kbc_read_ob(),ec_kbc_read_ob(),ec_kbc_read_ob(),
+ printk(BIOS_DEBUG, " EC Project: %c%c%c%c%c\n",
+ ec_kbc_read_ob(), ec_kbc_read_ob(), ec_kbc_read_ob(),
ec_kbc_read_ob(), ec_kbc_read_ob());

/* Print the hardware revision */
- printk(BIOS_DEBUG," Parrot Revision %x\n", parrot_rev());
+ printk(BIOS_DEBUG, " Parrot Revision %x\n", parrot_rev());

/* US Keyboard */
ec_kbc_write_cmd(0x59);

To view, visit change 49198. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5533c4fc7aa0e986da4350ec56b84903b3111a07
Gerrit-Change-Number: 49198
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged