Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34370 )
Change subject: device/device_util.c: Correct format specifier ......................................................................
device/device_util.c: Correct format specifier
path.mmio.addr is a uintptr_t, which is an unsigned long.
Change-Id: I5e43e0ab65cf59819abe1dde43143ff98e4553b0 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1402110 --- M src/device/device_util.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/34370/1
diff --git a/src/device/device_util.c b/src/device/device_util.c index 7ded1df..3f503b5 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -229,7 +229,7 @@ dev->path.usb.port_type, dev->path.usb.port_id); break; case DEVICE_PATH_MMIO: - snprintf(buffer, sizeof(buffer), "MMIO: %08x", + snprintf(buffer, sizeof(buffer), "MMIO: %08lx", dev->path.mmio.addr); break; default:
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34370 )
Change subject: device/device_util.c: Correct format specifier ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34370 )
Change subject: device/device_util.c: Correct format specifier ......................................................................
device/device_util.c: Correct format specifier
path.mmio.addr is a uintptr_t, which is an unsigned long.
Change-Id: I5e43e0ab65cf59819abe1dde43143ff98e4553b0 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Found-by: Coverity CID 1402110 Reviewed-on: https://review.coreboot.org/c/coreboot/+/34370 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M src/device/device_util.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved
diff --git a/src/device/device_util.c b/src/device/device_util.c index 7ded1df..3f503b5 100644 --- a/src/device/device_util.c +++ b/src/device/device_util.c @@ -229,7 +229,7 @@ dev->path.usb.port_type, dev->path.usb.port_id); break; case DEVICE_PATH_MMIO: - snprintf(buffer, sizeof(buffer), "MMIO: %08x", + snprintf(buffer, sizeof(buffer), "MMIO: %08lx", dev->path.mmio.addr); break; default:
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Patrick Georgi (Code Review)